Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2252573003: Add PDFExtensionTest.DownloadPDFButton

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bug_638087
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PDFExtensionTest.DownloadPDFButton BUG=638087

Patch Set 1 #

Patch Set 2 : missing changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -14 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 11 chunks +66 lines, -14 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
Lei Zhang
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 15:36:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252573003/1
4 years, 4 months ago (2016-08-16 15:37:01 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-16 15:52:09 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/261923)
4 years, 4 months ago (2016-08-16 15:52:10 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 15:57:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252573003/20001
4 years, 4 months ago (2016-08-16 15:58:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-16 16:41:23 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 16:41:23 UTC) #8 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698