Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2246303003: Use testharness.js instead of js-test.js in fast/images. (Closed)

Created:
4 years, 4 months ago by sivag
Modified:
4 years, 4 months ago
Reviewers:
Srirama, fs
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in fast/images. This patch replaces js-test.js with testharness.js in 1.Onload event after reloading image test. 2.Document add remove listener test. and changes DOCTYPE declarations in border.html and cmyk-jpeg-with-color-profile.html. BUG=637859 Committed: https://crrev.com/79331e5aff1549688db5bcde820812827e6fbd97 Cr-Commit-Position: refs/heads/master@{#412235}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Modify test as per the comments. #

Messages

Total messages: 13 (6 generated)
sivag
ptal..
4 years, 4 months ago (2016-08-16 09:31:02 UTC) #4
fs
https://codereview.chromium.org/2246303003/diff/1/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html File third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html (left): https://codereview.chromium.org/2246303003/diff/1/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html#oldcode12 third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html:12: testRunner.setCanOpenWindows(); Don't you still need this? https://codereview.chromium.org/2246303003/diff/1/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html File third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html ...
4 years, 4 months ago (2016-08-16 10:54:59 UTC) #5
sivag
https://codereview.chromium.org/2246303003/diff/1/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html File third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html (left): https://codereview.chromium.org/2246303003/diff/1/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html#oldcode12 third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html:12: testRunner.setCanOpenWindows(); On 2016/08/16 10:54:59, fs wrote: > Don't you ...
4 years, 4 months ago (2016-08-16 13:44:03 UTC) #6
fs
lgtm
4 years, 4 months ago (2016-08-16 13:48:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246303003/20001
4 years, 4 months ago (2016-08-16 13:50:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 14:56:44 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 14:58:39 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/79331e5aff1549688db5bcde820812827e6fbd97
Cr-Commit-Position: refs/heads/master@{#412235}

Powered by Google App Engine
This is Rietveld 408576698