third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html - Issue 2246303003: Use testharness.js instead of js-test.js in fast/images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html

Issue 2246303003: Use testharness.js instead of js-test.js in fast/images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modify test as per the comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html ('k') | third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html

diff --git a/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html b/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html

index ea833ef780feb9c43ee952b3d713b5c48feac58d..8b953f361bbe95d4d59b4f458772b3d87882f1d0 100644

--- a/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html

+++ b/third_party/WebKit/LayoutTests/fast/images/image-document-remove-listener.html

@@ -1,29 +1,16 @@

<!DOCTYPE html>

-<html>

-<script src="../../resources/js-test.js"></script>

-<body>

+<title>Test that removing invalid event listeners from image documents doesn't crash.</title>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

-description("Test that removing invalid event listeners from image documents doesn't crash.");

-window.jsTestIsAsync = true;

-if (window.testRunner) {

- testRunner.dumpAsText();

- testRunner.setCanOpenWindows();

- testRunner.waitUntilDone();

-function runTest()

+async_test(function(t) {

+ if (window.testRunner) {

+ testRunner.setCanOpenWindows();

+ }

var newWindow = window.open("resources/dice.png");

- newWindow.onload = function() {

+ newWindow.onload = t.step_func_done(function() {

newWindow.addEventListener("resize", function () {;});

newWindow.removeEventListener("resize", 2);

- testPassed("No crash.");

- finishJSTest();

- };

-runTest();

+ });

+});

</script>

-</body>

-</html>