Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorSession.h

Issue 2246233002: [DevTools] Move platform/v8_inspector classes under v8_inspector namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorSession.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorSession.h b/third_party/WebKit/Source/core/inspector/InspectorSession.h
index 22addfe86a40a14b3e0c95a20ca52d26eb009978..bcd453af230d1d95a77fe8170ab8a5742d15c2d2 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorSession.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorSession.h
@@ -12,14 +12,17 @@
#include "wtf/Vector.h"
#include "wtf/text/WTFString.h"
+namespace v8_inspector {
+class V8Inspector;
+class V8InspectorSession;
+}
+
namespace blink {
class ExecutionContext;
class InspectorAgent;
class InstrumentingAgents;
class LocalFrame;
-class V8Inspector;
-class V8InspectorSession;
class CORE_EXPORT InspectorSession
: public GarbageCollectedFinalized<InspectorSession>
@@ -32,10 +35,10 @@ public:
virtual ~Client() {}
};
- InspectorSession(Client*, InstrumentingAgents*, int sessionId, V8Inspector*, int contextGroupId, const String* savedState);
+ InspectorSession(Client*, InstrumentingAgents*, int sessionId, v8_inspector::V8Inspector*, int contextGroupId, const String* savedState);
~InspectorSession() override;
int sessionId() { return m_sessionId; }
- V8InspectorSession* v8Session() { return m_v8Session.get(); }
+ v8_inspector::V8InspectorSession* v8Session() { return m_v8Session.get(); }
void append(InspectorAgent*);
void restore();
@@ -52,7 +55,7 @@ private:
void sendProtocolNotification(const protocol::String16& message) override;
Client* m_client;
- std::unique_ptr<V8InspectorSession> m_v8Session;
+ std::unique_ptr<v8_inspector::V8InspectorSession> m_v8Session;
int m_sessionId;
bool m_disposed;
Member<InstrumentingAgents> m_instrumentingAgents;

Powered by Google App Engine
This is Rietveld 408576698