third_party/WebKit/Source/core/inspector/InspectorSession.cpp - Issue 2246233002: [DevTools] Move platform/v8_inspector classes under v8_inspector namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorSession.cpp

Issue 2246233002: [DevTools] Move platform/v8_inspector classes under v8_inspector namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorSession.h ('k') | third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorSession.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp

index fd7f04ca263faefb6b4b9d3072751f870a8db49c..75fd9290fcf87fccc0d90e8e1274cf39dbddf555 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp

@@ -18,7 +18,7 @@ namespace {

const char kV8StateKey[] = "v8";

}

-InspectorSession::InspectorSession(Client* client, InstrumentingAgents* instrumentingAgents, int sessionId, V8Inspector* inspector, int contextGroupId, const String* savedState)

+InspectorSession::InspectorSession(Client* client, InstrumentingAgents* instrumentingAgents, int sessionId, v8_inspector::V8Inspector* inspector, int contextGroupId, const String* savedState)

: m_client(client)

, m_v8Session(nullptr)

, m_sessionId(sessionId)

@@ -73,7 +73,7 @@ void InspectorSession::dispose()

void InspectorSession::dispatchProtocolMessage(const String& method, const String& message)

{

DCHECK(!m_disposed);

- if (V8InspectorSession::canDispatchMethod(method))

+ if (v8_inspector::V8InspectorSession::canDispatchMethod(method))

m_v8Session->dispatchProtocolMessage(message);

else

m_inspectorBackendDispatcher->dispatch(message);