Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2246033002: [MD History] Fix the 'Remove from history' button. (Closed)

Created:
4 years, 4 months ago by calamity
Modified:
4 years, 4 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@shift_select
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Fix the 'Remove from history' button. This CL fixes the 'Remove from history' button which was broken by r411253 and adds a test. BUG=637199 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4d276ca3e0873ddd68d41de237606d057c20df4b Cr-Commit-Position: refs/heads/master@{#412129}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M chrome/browser/resources/md_history/history_item.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 2 chunks +38 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
calamity
4 years, 4 months ago (2016-08-15 07:24:27 UTC) #3
tsergeant
lgtm
4 years, 4 months ago (2016-08-16 00:48:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246033002/20001
4 years, 4 months ago (2016-08-16 00:51:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 01:51:13 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 01:53:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d276ca3e0873ddd68d41de237606d057c20df4b
Cr-Commit-Position: refs/heads/master@{#412129}

Powered by Google App Engine
This is Rietveld 408576698