Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22460011: [CleanUp] Use base::STLSetDifference in place of std::set_difference (Closed)

Created:
7 years, 4 months ago by Haojian Wu
Modified:
7 years, 4 months ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tommycli, benjhayden+dwatch_chromium.org, tfarina, rpetterson, groby+spellwatch_chromium.org, browser-components-watch_chromium.org, rouslan+spellwatch_chromium.org, Lei Zhang, Greg Billock, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[CleanUp] Use base::STLSetDifference in place of std::set_difference BUG=254066 TEST=compiled Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219264

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Lei's comment #

Patch Set 3 : Address abarth's comment #

Patch Set 4 : Fix mac build error. #

Patch Set 5 : Add missing head file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -101 lines) Patch
M chrome/browser/download/download_history_unittest.cc View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/extensions/blacklist.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 1 chunk +6 lines, -10 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/feedback.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/spellchecker/feedback_sender.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 3 chunks +6 lines, -18 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M extensions/common/matcher/url_matcher.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M ui/base/test/ui_cocoa_test_helper.mm View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
Haojian Wu
asanka@ for c/b/d/download_history_unittest.cc kalman@ for c/b/e/blacklist.cc, c/b/e/extension_service.cc, c/c/e/permissions/permission_set.cc brettw@ for c/b/h/url_index_private_data.cc thestig@ for c/b/m/media_file_system_registry.cc rlp@ ...
7 years, 4 months ago (2013-08-10 07:20:42 UTC) #1
Lei Zhang
chrome/ lgtm https://codereview.chromium.org/22460011/diff/1/ui/base/test/ui_cocoa_test_helper.mm File ui/base/test/ui_cocoa_test_helper.mm (right): https://codereview.chromium.org/22460011/diff/1/ui/base/test/ui_cocoa_test_helper.mm#newcode183 ui/base/test/ui_cocoa_test_helper.mm:183: base::STLSetDifference<NSWindow*>(windows, initial_windows); typo
7 years, 4 months ago (2013-08-10 08:26:10 UTC) #2
abarth-chromium
I don't understand what problem this CL solves.
7 years, 4 months ago (2013-08-10 08:33:05 UTC) #3
Haojian Wu
https://codereview.chromium.org/22460011/diff/1/ui/base/test/ui_cocoa_test_helper.mm File ui/base/test/ui_cocoa_test_helper.mm (right): https://codereview.chromium.org/22460011/diff/1/ui/base/test/ui_cocoa_test_helper.mm#newcode183 ui/base/test/ui_cocoa_test_helper.mm:183: base::STLSetDifference<NSWindow*>(windows, initial_windows); On 2013/08/10 08:26:10, Lei Zhang wrote: > ...
7 years, 4 months ago (2013-08-10 09:47:29 UTC) #4
Haojian Wu
On 2013/08/10 08:33:05, abarth wrote: > I don't understand what problem this CL solves. This ...
7 years, 4 months ago (2013-08-10 09:49:19 UTC) #5
abarth-chromium
I would prefer if you did not include mime_util.cc in this CL. I don't believe ...
7 years, 4 months ago (2013-08-10 15:50:41 UTC) #6
Haojian Wu
On 2013/08/10 15:50:41, abarth wrote: > I would prefer if you did not include mime_util.cc ...
7 years, 4 months ago (2013-08-11 10:26:50 UTC) #7
rpetterson
spellcheck LGTM
7 years, 4 months ago (2013-08-12 18:46:32 UTC) #8
jbauman
On 2013/08/10 07:20:42, Haojian Wu wrote: > jbauman@ for u/b/t/ui_cocoa_test_helper.mm Sorry, I don't own that ...
7 years, 4 months ago (2013-08-12 18:47:44 UTC) #9
asanka
download LGTM
7 years, 4 months ago (2013-08-12 18:53:42 UTC) #10
battre
e/c/m/url_matcher.cc LGTM
7 years, 4 months ago (2013-08-12 20:50:47 UTC) #11
brettw
lgtm
7 years, 4 months ago (2013-08-12 23:33:24 UTC) #12
Haojian Wu
On 2013/08/12 23:33:24, brettw wrote: > lgtm jam@ need your LGTM for u/b/t/ui_cocoa_test_helper.mm. ping kalman@.
7 years, 4 months ago (2013-08-15 07:50:47 UTC) #13
not at google - send to devlin
lgtm
7 years, 4 months ago (2013-08-15 14:49:33 UTC) #14
Haojian Wu
On 2013/08/15 14:49:33, kalman wrote: > lgtm ping sky@ for chrome/browser/ui/ related changes.
7 years, 4 months ago (2013-08-21 01:32:10 UTC) #15
sky
LGTM
7 years, 4 months ago (2013-08-21 14:19:32 UTC) #16
Haojian Wu
ping rsesek@ for ui/base/test/ui_cocoa_test_helper.mm
7 years, 4 months ago (2013-08-21 23:59:40 UTC) #17
Robert Sesek
lgtm
7 years, 4 months ago (2013-08-22 13:07:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22460011/17001
7 years, 4 months ago (2013-08-22 13:18:20 UTC) #19
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-22 13:46:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22460011/39001
7 years, 4 months ago (2013-08-22 14:20:47 UTC) #21
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-22 14:40:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22460011/39001
7 years, 4 months ago (2013-08-23 08:14:07 UTC) #23
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-23 08:53:56 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22460011/39001
7 years, 4 months ago (2013-08-23 09:46:30 UTC) #25
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 11:52:59 UTC) #26
Message was sent while issue was closed. 
Change committed as 219264

Powered by Google App Engine
This is Rietveld 408576698