Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: chrome/browser/download/download_history_unittest.cc

Issue 22460011: [CleanUp] Use base::STLSetDifference in place of std::set_difference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing head file. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_history_unittest.cc
diff --git a/chrome/browser/download/download_history_unittest.cc b/chrome/browser/download/download_history_unittest.cc
index 93fdb73e4292bfefd22eec4a104f98a54e61b43c..0316883af53315d071c2e778266ce085da25f2e0 100644
--- a/chrome/browser/download/download_history_unittest.cc
+++ b/chrome/browser/download/download_history_unittest.cc
@@ -171,13 +171,7 @@ class FakeHistoryAdapter : public DownloadHistory::HistoryAdapter {
void ExpectDownloadsRemoved(const IdSet& ids) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
content::RunAllPendingInMessageLoop(content::BrowserThread::UI);
- IdSet differences;
- std::insert_iterator<IdSet> differences_iter(
- differences, differences.begin());
- std::set_difference(ids.begin(), ids.end(),
- remove_downloads_.begin(),
- remove_downloads_.end(),
- differences_iter);
+ IdSet differences = base::STLSetDifference<IdSet>(ids, remove_downloads_);
for (IdSet::const_iterator different = differences.begin();
different != differences.end(); ++different) {
EXPECT_TRUE(false) << *different;
« no previous file with comments | « no previous file | chrome/browser/extensions/blacklist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698