Add Android Shadow sample

Add Android Shadow sample

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245693002

Committed: https://skia.googlesource.com/skia/+/e1a3bc67690886dbc72271f447dec073363fe84c

[jvanverth1, 2016-08-12 15:34:36]

Description was changed from

==========
Add Android Shadow sample

BUG=skia:
==========

to

==========
Add Android Shadow sample

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245693002
==========

[jvanverth1, 2016-08-12 15:43:05]

jvanverth@google.com changed reviewers:
+ djsollen@google.com, robertphillips@google.com

[jvanverth1, 2016-08-12 15:43:06]

This is the full implementation (our version) of the Material Design shadows
with point lights, in Sample form.

[robertphillips, 2016-08-12 15:55:01]

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
File samplecode/SampleAndroidShadows.cpp (right):

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:2: /*
time warp

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:21: SkPath    fCirclePath;
Do we use these last 3 ?

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:39: fLightPos = SkPoint3::Make(-220, -330,
256);
I feel we should init the bools in the ctor

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:73: 
move out of class or make GetOcclRect ?

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:108: paint.setAntiAlias(true);
std::move(mf) ?

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:149: get_occl_rect(path, &occlRect);
Is this explicit xform necessary? occlRect should be in the same space as
'path'.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:162: paint.setAntiAlias(true);
here too ?

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:184: if (fShowAmbient) {
this-> ?

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:187: if (fShowSpot) {
Here too ?

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:195: void onDrawContent(SkCanvas* canvas)
override {
this-> ?

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:202: canvas->translate(200, 200);
?

[jvanverth1, 2016-08-12 16:43:44]

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
File samplecode/SampleAndroidShadows.cpp (right):

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:2: /*
On 2016/08/12 15:55:01, robertphillips wrote:
> time warp

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:21: SkPath    fCirclePath;
On 2016/08/12 15:55:01, robertphillips wrote:
> Do we use these last 3 ?

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:39: fLightPos = SkPoint3::Make(-220, -330,
256);
On 2016/08/12 15:55:01, robertphillips wrote:
> I feel we should init the bools in the ctor

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:73: 
On 2016/08/12 15:55:01, robertphillips wrote:
> move out of class or make GetOcclRect ?

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:108: paint.setAntiAlias(true);
On 2016/08/12 15:55:01, robertphillips wrote:
> std::move(mf) ?

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:149: get_occl_rect(path, &occlRect);
On 2016/08/12 15:55:01, robertphillips wrote:
> Is this explicit xform necessary? occlRect should be in the same space as
> 'path'.

Yes, it is (though the xform needs to be scale, then translate).

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:162: paint.setAntiAlias(true);
On 2016/08/12 15:55:01, robertphillips wrote:
> here too ?

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:184: if (fShowAmbient) {
On 2016/08/12 15:55:01, robertphillips wrote:
> this-> ?

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:187: if (fShowSpot) {
On 2016/08/12 15:55:01, robertphillips wrote:
> Here too ?

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:195: void onDrawContent(SkCanvas* canvas)
override {
On 2016/08/12 15:55:01, robertphillips wrote:
> this-> ?

Done.

https://codereview.chromium.org/2245693002/diff/20001/samplecode/SampleAndroi...
samplecode/SampleAndroidShadows.cpp:202: canvas->translate(200, 200);
On 2016/08/12 15:55:01, robertphillips wrote:
> ?

Done.

[robertphillips, 2016-08-12 16:55:59]

lgtm

[robertphillips, 2016-08-12 16:56:06]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:56:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:13:11]

Dry run: This issue passed the CQ dry run.

[jvanverth1, 2016-08-12 17:39:36]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-08-12 17:39:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:40:41]

Description was changed from

==========
Add Android Shadow sample

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245693002
==========

to

==========
Add Android Shadow sample

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245693002

Committed:
https://skia.googlesource.com/skia/+/e1a3bc67690886dbc72271f447dec073363fe84c
==========

[commit-bot: I haz the power, 2016-08-12 17:40:41]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e1a3bc67690886dbc72271f447dec073363fe84c