Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 224563004: sync: Re-implement getAllNodes WebUI function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style fixes + comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index 79b2a52657a5ed9577560b9a270eaa7320710a91..695f79aa77726996d1736056fef601e0faa3722b 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -276,6 +276,14 @@ class ProfileSyncService : public ProfileSyncServiceBase,
void RemoveProtocolEventObserver(
browser_sync::ProtocolEventObserver* observer);
+ // Asynchronously fetches base::Value representations of all sync nodes and
+ // returns to this the specified callback on this thread.
Nicolas Zea 2014/04/04 23:01:27 "and returns to this the specified" -> "and return
rlarocque 2014/04/05 00:07:27 Done.
+ //
+ // These requests can live a long time and return when you least expect it.
+ // For safety, the callback should contain some sort of WeakPtr<> or
Nicolas Zea 2014/04/04 23:01:27 "should contain" -> "should be bound to"
rlarocque 2014/04/05 00:07:27 Done.
+ // scoped_refptr<>.
+ void GetAllNodes(base::Callback<void(scoped_ptr<base::ListValue>)>);
+
void RegisterAuthNotifications();
void UnregisterAuthNotifications();

Powered by Google App Engine
This is Rietveld 408576698