sync: Re-implement getAllNodes WebUI function

chrome/browser/sync/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 258 matching lines @@
   virtual void RemoveObserver(
       ProfileSyncServiceBase::Observer* observer) OVERRIDE;
   virtual bool HasObserver(
       ProfileSyncServiceBase::Observer* observer) const OVERRIDE;
 
 
   void AddProtocolEventObserver(browser_sync::ProtocolEventObserver* observer);
   void RemoveProtocolEventObserver(
       browser_sync::ProtocolEventObserver* observer);
 
+  // Asynchronously fetches base::Value representations of all sync nodes and
+  // returns to this the specified callback on this thread.

[Nicolas Zea, 2014/04/04 23:01:27]

"and returns to this the specified" -> "and returns them to the specified"

[rlarocque, 2014/04/05 00:07:27]

Done.

+  //
+  // These requests can live a long time and return when you least expect it.
+  // For safety, the callback should contain some sort of WeakPtr<> or

[Nicolas Zea, 2014/04/04 23:01:27]

"should contain" -> "should be bound to"

[rlarocque, 2014/04/05 00:07:27]

Done.

+  // scoped_refptr<>.
+  void GetAllNodes(base::Callback<void(scoped_ptr<base::ListValue>)>);
+
   void RegisterAuthNotifications();
   void UnregisterAuthNotifications();
 
   // Returns true if sync is enabled/not suppressed and the user is logged in.
   // (being logged in does not mean that tokens are available - tokens may
   // be missing because they have not loaded yet, or because they were deleted
   // due to http://crbug.com/121755).
   // Virtual to enable mocking in tests.
   // TODO(tim): Remove this? Nothing in ProfileSyncService uses it, and outside
   // callers use a seemingly arbitrary / redundant / bug prone combination of
@@ skipping 725 matching lines @@
   browser_sync::StartupController startup_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const syncer::SyncProtocolError& error);
 
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_