Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: content/browser/bluetooth/bluetooth_device_chooser_controller.cc

Issue 2245603003: Add signal strength indicator icon to WebBluetooth chooser on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added signal strength indicator icon to WebBluetooth chooser Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_device_chooser_controller.cc
diff --git a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
index b2d8792f0c4a5fd5ddccd1b9594b719793ec41df..38f42438be0a581a0243b0aa0619bbd892a72238 100644
--- a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
+++ b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
@@ -339,14 +339,14 @@ void BluetoothDeviceChooserController::GetDevice(
void BluetoothDeviceChooserController::AddFilteredDevice(
const device::BluetoothDevice& device) {
if (chooser_.get() && MatchesFilters(device, options_->filters)) {
+ base::Optional<int8_t> rssi = device.GetInquiryRSSI();
chooser_->AddOrUpdateDevice(
device.GetAddress(),
// TODO(https://crbug.com/634366): Update device's name when necessary.
false /* should_update_name */, device.GetNameForDisplay(),
// TODO(http://crbug.com/543466): Show connection and paired status.
false /* is_gatt_connected */, false /* is_paired */,
- // TODO(http://crbug.com/629689): Add signal strength indicator.
- nullptr /* rssi */);
+ rssi ? &(rssi.value()) : nullptr);
msw 2016/08/12 23:08:49 Just pass a plain int8_t, instead of a const point
juncai 2016/08/15 21:53:20 Some context: We discussed this at: https://codere
}
}

Powered by Google App Engine
This is Rietveld 408576698