chrome/browser/usb/usb_chooser_controller.h - Issue 2245603003: Add signal strength indicator icon to WebBluetooth chooser on non-Mac desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/usb_chooser_controller.h

Issue 2245603003: Add signal strength indicator icon to WebBluetooth chooser on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added signal strength indicator icon to WebBluetooth chooser Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/chooser_content_view.cc ('K') | « chrome/browser/ui/views/chooser_content_view.cc ('k') | chrome/browser/usb/usb_chooser_controller.cc » ('j') | content/browser/bluetooth/bluetooth_device_chooser_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/usb/usb_chooser_controller.h

diff --git a/chrome/browser/usb/usb_chooser_controller.h b/chrome/browser/usb/usb_chooser_controller.h

index c713112e8f54fc1d6ddf4b6ada70c96b6957518c..782182a644c7cd2d61f9fdb6e3e3cb5f0f762103 100644

--- a/chrome/browser/usb/usb_chooser_controller.h

+++ b/chrome/browser/usb/usb_chooser_controller.h

@@ -40,9 +40,11 @@ class UsbChooserController : public ChooserController,

~UsbChooserController() override;

// ChooserController:

+ bool HasIconBeforeText() const override;

base::string16 GetNoOptionsText() const override;

base::string16 GetOkButtonLabel() const override;

size_t NumOptions() const override;

+ int GetSignalStrengthLevel(size_t index) const override;

Reilly Grant (use Gerrit) 2016/08/12 20:28:16 ChooserController could be given a default impleme

juncai 2016/08/15 21:53:20 Done.

base::string16 GetOption(size_t index) const override;

void RefreshOptions() override;

base::string16 GetStatus() const override;