Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2245483006: Revert of Disable MetricsServiceBrowserTest.CrashRenderers on Windows (Closed)

Created:
4 years, 4 months ago by Alexei Svitkine (slow)
Modified:
4 years, 4 months ago
Reviewers:
foolip
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable MetricsServiceBrowserTest.CrashRenderers on Windows (patchset #1 id:1 of https://codereview.chromium.org/2223353003/ ) Reason for revert: Re-enabling test given the underlying issue has been fixed. Original issue's description: > Disable MetricsServiceBrowserTest.CrashRenderers on Windows > > The final DCHECK in MetricsStateManager::LoadClientInfoAndMaybeMigrate > is failing flakily. > > BUG=635770 > TBR=asvitkine@chromium.org > > Committed: https://crrev.com/a5445ce1c75599a59781e686303627dfa468e47a > Cr-Commit-Position: refs/heads/master@{#410613} TBR=foolip@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635770 Committed: https://crrev.com/192808d9c44b9323ca407186a0b4b5504f34f392 Cr-Commit-Position: refs/heads/master@{#411836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/metrics/metrics_service_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Alexei Svitkine (slow)
Created Revert of Disable MetricsServiceBrowserTest.CrashRenderers on Windows
4 years, 4 months ago (2016-08-13 00:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245483006/1
4 years, 4 months ago (2016-08-13 00:16:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 00:47:58 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 00:51:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/192808d9c44b9323ca407186a0b4b5504f34f392
Cr-Commit-Position: refs/heads/master@{#411836}

Powered by Google App Engine
This is Rietveld 408576698