Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG=635785
Committed: https://crrev.com/b0afef87f6ef1567a88011c97ac86dc09db75256
Cr-Commit-Position: refs/heads/master@{#411733}

[Mark P, 2016-08-11 21:50:01]

Description was changed from

==========
Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG=635785
==========

to

==========
Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG=635785
==========

[Mark P, 2016-08-11 21:50:01]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2016-08-11 21:50:28]

Please take a look, thanks.

--mark

[Peter Kasting, 2016-08-11 21:58:27]

LGTM.  I worried about a potential case where we do a drag while the omnibox had
focus, thus recording a misleading time value.  But in testing I couldn't find a
way to make that occur.  So I think this is safe.

[Mark P, 2016-08-11 22:08:02]

mpearson@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Mark P, 2016-08-11 22:08:29]

+rkaplow
to officially review my histograms.xml change.

--mark

[rkaplow, 2016-08-11 22:13:23]

lgtm

https://codereview.chromium.org/2245443002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2245443002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:37115: +    histogram to the total
number of omnibox events.
nit - you could call out "the total number of omnibox events" by histogram name
to make it a bit easier for the reader.

[Mark P, 2016-08-11 22:17:58]

https://codereview.chromium.org/2245443002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2245443002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:37115: +    histogram to the total
number of omnibox events.
On 2016/08/11 22:13:22, rkaplow wrote:
> nit - you could call out "the total number of omnibox events" by histogram
name
> to make it a bit easier for the reader.

Acknowledged.  Except it's a synthetic histogram, so I feel weird about calling
it out here.  Users should either look at the underlying logs omnibox_event
protos or search our dashboard.

[Mark P, 2016-08-11 22:51:55]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:53:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:38:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark P, 2016-08-12 03:54:34]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2016-08-12 03:54:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 04:57:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 04:57:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark P, 2016-08-12 19:04:02]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2016-08-12 19:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 19:33:53]

Description was changed from

==========
Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG=635785
==========

to

==========
Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG=635785
==========

[commit-bot: I haz the power, 2016-08-12 19:33:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 19:35:31]

Description was changed from

==========
Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG=635785
==========

to

==========
Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG=635785

Committed: https://crrev.com/b0afef87f6ef1567a88011c97ac86dc09db75256
Cr-Commit-Position: refs/heads/master@{#411733}
==========

[commit-bot: I haz the power, 2016-08-12 19:35:32]

Patchset 1 (id:??) landed as
https://crrev.com/b0afef87f6ef1567a88011c97ac86dc09db75256
Cr-Commit-Position: refs/heads/master@{#411733}