Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2245443002: Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/omnibox/browser/omnibox_edit_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b58432248bb663f63c5decdeca1fa6413b0347d1..101ba924770164bee4ec7022dcaf8cd68eb42e94 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -37092,6 +37092,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Omnibox.FocusToOpenTimeAnyPopupState" units="ms">
<owner>mpearson@chromium.org</owner>
+ <obsolete>
+ Replaced with Omnibox.FocusToOpenTimeAnyPopupState2 in August, 2016.
+ </obsolete>
<summary>
The length of time between when a user focused on the omnibox and opened an
omnibox match (which could be what they typed or a suggestion). This is
@@ -37099,6 +37102,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Omnibox.FocusToOpenTimeAnyPopupState2" units="ms">
+ <owner>mpearson@chromium.org</owner>
+ <summary>
+ The length of time between when a user focused on the omnibox and opened an
+ omnibox match (which could be what they typed or a suggestion). This is
+ recorded regardless of whether the omnibox dropdown (a.k.a. popup) is open.
+ It is not recorded if a match is opened without triggering a focus event,
+ e.g., when a user drags a URL to the omnibox to navigate.
+
+ To know how common this last condition is, compare the total count of this
+ histogram to the total number of omnibox events.
rkaplow 2016/08/11 22:13:22 nit - you could call out "the total number of omni
Mark P 2016/08/11 22:17:58 Acknowledged. Except it's a synthetic histogram,
+ </summary>
+</histogram>
+
<histogram name="Omnibox.HardwareKeyboardModeEnabled" enum="BooleanEnabled">
<owner>lpromero@chromium.org</owner>
<summary>
« no previous file with comments | « components/omnibox/browser/omnibox_edit_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698