Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2245133004: [heap] Add basic infrastructure for incremental wrapper tracing. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich, haraken
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add basic infrastructure for incremental wrapper tracing. BUG=chromium:468240 Committed: https://crrev.com/03d5f87597111f51a6d508abd55d96e2096ba704 Cr-Commit-Position: refs/heads/master@{#38702}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Hannes Payer (out of office)
4 years, 4 months ago (2016-08-16 12:13:49 UTC) #4
Michael Lippautz
lgtm https://codereview.chromium.org/2245133004/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2245133004/diff/1/src/heap/incremental-marking.cc#newcode1207 src/heap/incremental-marking.cc:1207: // respect bytes_to_priocess. nit: s/bytes_to_priocess/bytes_to_process/
4 years, 4 months ago (2016-08-16 12:50:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245133004/20001
4 years, 4 months ago (2016-08-18 08:12:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 08:45:31 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:45:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03d5f87597111f51a6d508abd55d96e2096ba704
Cr-Commit-Position: refs/heads/master@{#38702}

Powered by Google App Engine
This is Rietveld 408576698