Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: src/heap/incremental-marking.cc

Issue 2245133004: [heap] Add basic infrastructure for incremental wrapper tracing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/mark-compact.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/incremental-marking.cc
diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc
index 0c0f5b408ee5ae573dcdc8f533e7ad9d3987f620..321d443caef7603b1cbad727a2e1ff7a34a457d2 100644
--- a/src/heap/incremental-marking.cc
+++ b/src/heap/incremental-marking.cc
@@ -1201,6 +1201,19 @@ intptr_t IncrementalMarking::Step(intptr_t allocated_bytes,
if (state_ == MARKING) {
bytes_processed = ProcessMarkingDeque(bytes_to_process);
+ if (FLAG_incremental_marking_wrappers &&
+ heap_->UsingEmbedderHeapTracer()) {
+ // This currently marks through all registered wrappers and does not
+ // respect bytes_to_process.
+ // TODO(hpayer): Integrate incremental marking of wrappers into
+ // bytes_to_process logic.
+ heap_->mark_compact_collector()
+ ->RegisterWrappersWithEmbedderHeapTracer();
+ heap_->mark_compact_collector()->embedder_heap_tracer()->AdvanceTracing(
+ 0,
+ EmbedderHeapTracer::AdvanceTracingActions(
+ EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION));
+ }
if (heap_->mark_compact_collector()->marking_deque()->IsEmpty()) {
if (completion == FORCE_COMPLETION ||
IsIdleMarkingDelayCounterLimitReached()) {
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698