ServiceWorker: Call SyncMatchingRegistration when document_url is changed

content/browser/service_worker/service_worker_provider_host.h

Index: content/browser/service_worker/service_worker_provider_host.h
diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h
index 0ca74533ce6542014a60acf86db9e28ffc29aace..82bc9845924f24767db82e20c69fff04c6da97dd 100644
--- a/content/browser/service_worker/service_worker_provider_host.h
+++ b/content/browser/service_worker/service_worker_provider_host.h
@@ -246,9 +246,6 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
   void AddMatchingRegistration(ServiceWorkerRegistration* registration);
   void RemoveMatchingRegistration(ServiceWorkerRegistration* registration);
 
-  // Add matched registrations for document generated by shift-reload.
-  void AddAllMatchingRegistrations();
-
   // An optimized implementation of [[Match Service Worker Registration]]
   // for current document.
   ServiceWorkerRegistration* MatchRegistration() const;
@@ -311,6 +308,11 @@ class CONTENT_EXPORT ServiceWorkerProviderHost
 
   void SendAssociateRegistrationMessage();
 
+  // Sync all live and matching registrations up with the context core

[nhiroki, 2016/08/22 06:35:49]

This sounds a bit strange because matching registrations should be synced up not
with the context core but with all live registrations. We could rewrite this
like...

  // Syncs up matching registrations with live registrations.

[shimazu, 2016/08/22 09:29:40]

Done.

+  void SyncMatchingRegistrations();

[nhiroki, 2016/08/22 06:35:49]

Can you add a blank line after this line?

[shimazu, 2016/08/22 09:29:40]

Done.

+  // Discard all references to matching registrations

[nhiroki, 2016/08/22 06:35:49]

s/Discard/Discard/

From the style guide:

"These comments should be descriptive ("Opens the file") rather than imperative
("Open the file")"
https://google.github.io/styleguide/cppguide.html#Function_Comments

[shimazu, 2016/08/22 09:29:40]

Done.

+  void RemoveAllMatchingRegistration();

[nhiroki, 2016/08/22 06:35:49]

RemoveAllMatchingRegistration"s"()

[shimazu, 2016/08/22 09:29:40]

Done.

+
   // Increase/decrease this host's process reference for |pattern|.
   void IncreaseProcessReference(const GURL& pattern);
   void DecreaseProcessReference(const GURL& pattern);