ServiceWorker: Call SyncMatchingRegistration when document_url is changed

content/browser/service_worker/service_worker_provider_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROVIDER_HOST_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROVIDER_HOST_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 119 matching lines @@
   ServiceWorkerRegistration* associated_registration() const {
     return associated_registration_.get();
   }
 
   // The running version, if any, that this provider is providing resource
   // loads for.
   ServiceWorkerVersion* running_hosted_version() const {
     return running_hosted_version_.get();
   }
 
   void SetDocumentUrl(const GURL& url);

[nhiroki, 2016/08/22 06:35:49]

Can you add a comment that this also updates matching registrations?

[shimazu, 2016/08/22 09:29:40]

Done.

   const GURL& document_url() const { return document_url_; }
 
   void SetTopmostFrameUrl(const GURL& url);
   const GURL& topmost_frame_url() const { return topmost_frame_url_; }
 
   ServiceWorkerProviderType provider_type() const { return provider_type_; }
   bool IsProviderForClient() const;
   blink::WebServiceWorkerClientType client_type() const;
 
   // Associates to |registration| to listen for its version change events and
@@ skipping 88 matching lines @@
   void SendServiceWorkerStateChangedMessage(
       int worker_handle_id,
       blink::WebServiceWorkerState state);
 
   // Sets the worker thread id and flushes queued events.
   void SetReadyToSendMessagesToWorker(int render_thread_id);
 
   void AddMatchingRegistration(ServiceWorkerRegistration* registration);
   void RemoveMatchingRegistration(ServiceWorkerRegistration* registration);
 
-  // Add matched registrations for document generated by shift-reload.
-  void AddAllMatchingRegistrations();
-
   // An optimized implementation of [[Match Service Worker Registration]]
   // for current document.
   ServiceWorkerRegistration* MatchRegistration() const;
 
   // Called when our controller has been terminated and doomed due to an
   // exceptional condition like it could no longer be read from the script
   // cache.
   void NotifyControllerLost();
 
  private:
@@ skipping 42 matching lines @@
   void OnSkippedWaiting(ServiceWorkerRegistration* registration) override;
 
   // Sets the controller version field to |version| or if |version| is NULL,
   // clears the field. If |notify_controllerchange| is true, instructs the
   // renderer to dispatch a 'controller' change event.
   void SetControllerVersionAttribute(ServiceWorkerVersion* version,
                                      bool notify_controllerchange);
 
   void SendAssociateRegistrationMessage();
 
+  // Sync all live and matching registrations up with the context core

[nhiroki, 2016/08/22 06:35:49]

This sounds a bit strange because matching registrations should be synced up not
with the context core but with all live registrations. We could rewrite this
like...

  // Syncs up matching registrations with live registrations.

[shimazu, 2016/08/22 09:29:40]

Done.

+  void SyncMatchingRegistrations();

[nhiroki, 2016/08/22 06:35:49]

Can you add a blank line after this line?

[shimazu, 2016/08/22 09:29:40]

Done.

+  // Discard all references to matching registrations

[nhiroki, 2016/08/22 06:35:49]

s/Discard/Discard/

From the style guide:

"These comments should be descriptive ("Opens the file") rather than imperative
("Open the file")"
https://google.github.io/styleguide/cppguide.html#Function_Comments

[shimazu, 2016/08/22 09:29:40]

Done.

+  void RemoveAllMatchingRegistration();

[nhiroki, 2016/08/22 06:35:49]

RemoveAllMatchingRegistration"s"()

[shimazu, 2016/08/22 09:29:40]

Done.

+
   // Increase/decrease this host's process reference for |pattern|.
   void IncreaseProcessReference(const GURL& pattern);
   void DecreaseProcessReference(const GURL& pattern);
 
   void ReturnRegistrationForReadyIfNeeded();
 
   bool IsReadyToSendMessages() const;
   void Send(IPC::Message* message) const;
 
   // Finalizes cross-site transfers and navigation-initalized hosts.
@@ skipping 40 matching lines @@
   bool allow_association_;
 
   std::vector<base::Closure> queued_events_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerProviderHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROVIDER_HOST_H_