Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2244983004: [elements, turbofan] Implement simple GrowElements (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements, turbofan] Implement simple GrowElements Unlike Crankshaft, Turbofan does not provide a context when trying to grow elements. Depending on the code path we might end up updating transitioning elements kinds in allocation sites for which we need access to the current context. Unlike GrowCapacityAndConvert, the newly introduced GrowCapacity simply returns false in cases where map transitions are involved. BUG=chromium:637279

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -17 lines) Patch
M src/elements.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/elements.cc View 1 chunk +21 lines, -0 lines 1 comment Download
M src/objects.h View 3 chunks +8 lines, -2 lines 0 comments Download
M src/objects.cc View 7 chunks +20 lines, -8 lines 1 comment Download
M src/runtime/runtime-array.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
4 years, 4 months ago (2016-08-16 13:01:55 UTC) #2
Michael Lippautz
Fixes the problem encountered with smaller pages! Thanks a lot. Karma++
4 years, 4 months ago (2016-08-16 13:14:42 UTC) #3
Camillo Bruni
PTAL.
4 years, 4 months ago (2016-08-16 13:16:21 UTC) #5
Jakob Kummerow
Looks good. https://codereview.chromium.org/2244983004/diff/1/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/2244983004/diff/1/src/elements.cc#newcode895 src/elements.cc:895: if (object->map()->is_prototype_map() || To explain why this ...
4 years, 4 months ago (2016-08-16 15:15:01 UTC) #7
Jakob Kummerow
4 years, 4 months ago (2016-08-18 14:11:51 UTC) #8
Stealing this at mlippautz' request and landing it at
https://codereview.chromium.org/2252393002

Powered by Google App Engine
This is Rietveld 408576698