Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2252393002: [elements, turbofan] Implement simple GrowElements (Closed)

Created:
4 years, 4 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Camillo Bruni
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements, turbofan] Implement simple GrowElements Unlike Crankshaft, Turbofan does not provide a context when trying to grow elements. Depending on the code path we might end up updating transitioning elements kinds in allocation sites for which we need access to the current context. Unlike GrowCapacityAndConvert, the newly introduced GrowCapacity simply returns false in cases where map transitions are involved. BUG=chromium:637279 Patch by Camillo Bruni <cbruni@chromium.org>;, originally reviewed at https://codereview.chromium.org/2244983004/ Committed: https://crrev.com/a9fd19f4d137a8a2f205288afd348a03255fa685 Cr-Commit-Position: refs/heads/master@{#38901}

Patch Set 1 : cbruni's patch #

Patch Set 2 : addressing comments #

Patch Set 3 : fix WouldConvertToSlow check #

Patch Set 4 : rebased #

Patch Set 5 : fix Android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M src/elements.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/elements.cc View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 3 4 7 chunks +23 lines, -8 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Jakob Kummerow
Michael: PTAL. Camillo: FYI.
4 years, 4 months ago (2016-08-18 14:12:34 UTC) #2
Michael Lippautz
lgtm thanks
4 years, 4 months ago (2016-08-18 14:17:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252393002/20001
4 years, 4 months ago (2016-08-18 14:18:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/7175) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-18 14:38:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252393002/60001
4 years, 4 months ago (2016-08-25 09:38:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/23365)
4 years, 3 months ago (2016-08-25 09:48:36 UTC) #12
Michael Lippautz
still lgtm % arm (looked at diff between PS2-PS3)
4 years, 3 months ago (2016-08-25 10:00:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252393002/80001
4 years, 3 months ago (2016-08-25 11:09:02 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-25 11:39:31 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:39:42 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a9fd19f4d137a8a2f205288afd348a03255fa685
Cr-Commit-Position: refs/heads/master@{#38901}

Powered by Google App Engine
This is Rietveld 408576698