Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2244893002: Remove the "card verified" message in PaymentRequest. (Closed)

Created:
4 years, 4 months ago by please use gerrit instead
Modified:
4 years, 4 months ago
Reviewers:
vabr (Chromium), Yaron
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the "card verified" message in PaymentRequest. The merchant website has the final say in whether the provided credit card is usable for the purchase. The merchant notifies the browser via complete("fail") when the card is rejected. Chrome shows an error dialog to the user when this happens. Therefore, CVC unmask dialog should not show the "card verified" message. This is doubly true for local cards, which are not verified against the server due to the privacy model. This patch removes the "card verified" message from PaymentRequest. Autofill card unmasking still has this message. BUG=637454 Committed: https://crrev.com/7ad99584c3051480f39d0a25173daad60ccf47b3 Cr-Commit-Position: refs/heads/master@{#412269}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 4 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
please use gerrit instead
vabr, ptal components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc. Yaron, ptal *android* (first 3 files).
4 years, 4 months ago (2016-08-13 05:07:51 UTC) #6
Yaron
lgtm
4 years, 4 months ago (2016-08-15 15:22:45 UTC) #7
vabr (Chromium)
lgtm
4 years, 4 months ago (2016-08-16 07:12:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244893002/1
4 years, 4 months ago (2016-08-16 15:47:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/52727)
4 years, 4 months ago (2016-08-16 15:49:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244893002/20001
4 years, 4 months ago (2016-08-16 16:25:32 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 17:07:59 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 17:09:42 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ad99584c3051480f39d0a25173daad60ccf47b3
Cr-Commit-Position: refs/heads/master@{#412269}

Powered by Google App Engine
This is Rietveld 408576698