Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3822)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java

Issue 2244893002: Remove the "card verified" message in PaymentRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
index 6e9fe936e08f3c6065106c31fbbfe0ea1d96e587..56eb25b68866ef171bfeb48285076d95e8d11a98 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
@@ -67,6 +67,7 @@ public class CardUnmaskPrompt
private final View mVerificationOverlay;
private final ProgressBar mVerificationProgressBar;
private final TextView mVerificationView;
+ private final long mSuccessMessageDurationMilliseconds;
private int mThisYear;
private int mThisMonth;
@@ -122,7 +123,7 @@ public class CardUnmaskPrompt
public CardUnmaskPrompt(Context context, CardUnmaskPromptDelegate delegate, String title,
String instructions, String confirmButtonLabel, int drawableId,
boolean shouldRequestExpirationDate, boolean canStoreLocally,
- boolean defaultToStoringLocally) {
+ boolean defaultToStoringLocally, long successMessageDurationMilliseconds) {
mDelegate = delegate;
LayoutInflater inflater = LayoutInflater.from(context);
@@ -148,6 +149,7 @@ public class CardUnmaskPrompt
mVerificationOverlay = v.findViewById(R.id.verification_overlay);
mVerificationProgressBar = (ProgressBar) v.findViewById(R.id.verification_progress_bar);
mVerificationView = (TextView) v.findViewById(R.id.verification_message);
+ mSuccessMessageDurationMilliseconds = successMessageDurationMilliseconds;
((ImageView) v.findViewById(R.id.cvc_hint_image)).setImageResource(drawableId);
mDialog = new AlertDialog.Builder(context, R.style.AlertDialogTheme)
@@ -244,17 +246,21 @@ public class CardUnmaskPrompt
setNoRetryError(errorMessage);
}
} else {
- mVerificationProgressBar.setVisibility(View.GONE);
- mDialog.findViewById(R.id.verification_success).setVisibility(View.VISIBLE);
- mVerificationView.setText(R.string.autofill_card_unmask_verification_success);
- mVerificationView.announceForAccessibility(mVerificationView.getText());
- Handler h = new Handler();
- h.postDelayed(new Runnable() {
+ Runnable dismissRunnable = new Runnable() {
@Override
public void run() {
dismiss();
}
- }, 1000);
+ };
+ if (mSuccessMessageDurationMilliseconds > 0) {
+ mVerificationProgressBar.setVisibility(View.GONE);
+ mDialog.findViewById(R.id.verification_success).setVisibility(View.VISIBLE);
+ mVerificationView.setText(R.string.autofill_card_unmask_verification_success);
+ mVerificationView.announceForAccessibility(mVerificationView.getText());
+ new Handler().postDelayed(dismissRunnable, mSuccessMessageDurationMilliseconds);
+ } else {
+ new Handler().post(dismissRunnable);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698