Issue 2244743002: Revert asserting only 1 arg ICs are generated in precompilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2244743002: Revert asserting only 1 arg ICs are generated in precompilation. (Closed)

Created:
4 years, 4 months ago by rmacnak

Modified:
4 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert asserting only 1 arg ICs are generated in precompilation. Committed: https://github.com/dart-lang/sdk/commit/87360dc375864ed4d3db6f13ef29474699001c19

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	runtime/vm/precompiler.cc	View		1 chunk	+1 line, -3 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

Committed patchset #1 (id:1) manually as 87360dc375864ed4d3db6f13ef29474699001c19 (presubmit successful).

4 years, 4 months ago (2016-08-12 17:09:10 UTC) #4

Florian Schneider

4 years, 4 months ago (2016-08-12 17:56:29 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2244743002/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2244743002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:1935: if (ic_.NumArgsTested() != 1) continue;
So we do still use ICs with >1 argument checks?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages