Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: runtime/vm/precompiler.cc

Issue 2244743002: Revert asserting only 1 arg ICs are generated in precompilation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index dcf3519c1d8c11322b00e788a3a64fdcbe6c7b7b..afb280423afdfa424a5f7cf194370b9eaa6371a5 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -1932,9 +1932,7 @@ void Precompiler::SwitchICCalls() {
if (entry_.IsICData()) {
ic_ ^= entry_.raw();
- // SwitchableCalls use single-check ICs. No other kind of IC call is
- // generated in precompilation mode.
- ASSERT(ic_.NumArgsTested() == 1);
+ if (ic_.NumArgsTested() != 1) continue;
Florian Schneider 2016/08/12 17:56:29 So we do still use ICs with >1 argument checks?
for (intptr_t j = 0; j < ic_.NumberOfChecks(); j++) {
entry_ = ic_.GetTargetOrCodeAt(j);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698