Issue 2244533002: Add a pre-finalizer to PromiseRejectionEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2244533002: Add a pre-finalizer to PromiseRejectionEvent (Closed)

Created:
4 years, 4 months ago by haraken

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Add a pre-finalizer to PromiseRejectionEvent We need to clear ScopedPersistents so that V8 doesn't call phantom callbacks after Oilpan starts lazy sweeping. BUG=626893 Review-Url: https://codereview.chromium.org/2196543003 Cr-Commit-Position: refs/heads/master@{#408742} (cherry picked from commit 07d2ad752c2749ca67adb8051bf5591f57e06046) Committed: https://chromium.googlesource.com/chromium/src/+/89fa8a4e8f4d77745e86b5176608b5d97204cf39

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/events/PromiseRejectionEvent.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

haraken

4 years, 4 months ago (2016-08-12 01:10:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89fa8a4e8f4d77745e86b5176608b5d97204cf39.