Add a pre-finalizer to PromiseRejectionEvent

Add a pre-finalizer to PromiseRejectionEvent

We need to clear ScopedPersistents so that V8 doesn't call phantom callbacks
after Oilpan starts lazy sweeping.

BUG=626893
Committed: https://crrev.com/07d2ad752c2749ca67adb8051bf5591f57e06046
Cr-Commit-Position: refs/heads/master@{#408742}

[haraken, 2016-07-29 15:47:05]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, sigbjornf@opera.com, ulan@chromium.org

[haraken, 2016-07-29 15:47:05]

PTAL

(I'd prefer a pre-finalizer since we need to use the OPERATOR_NEW macro if we
use EAGERLY_FINALIZE.)

[haraken, 2016-07-29 15:47:06]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 15:47:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-07-29 16:10:47]

lgtm, but it shows how unnatural a device prefinalizers are.

[sof, 2016-07-29 16:34:09]

https://codereview.chromium.org/2196543003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp (right):

https://codereview.chromium.org/2196543003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp:38:
m_promise.clear();
Please clear m_scriptState also.

[commit-bot: I haz the power, 2016-07-29 17:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:04:39]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-07-29 18:32:51]

On 2016/07/29 16:34:09, sof wrote:
>
https://codereview.chromium.org/2196543003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp (right):
> 
>
https://codereview.chromium.org/2196543003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp:38:
> m_promise.clear();
> Please clear m_scriptState also.

Done.

[haraken, 2016-07-29 18:33:04]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-07-29 18:33:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2196543003/#ps2 (title:
"temp")

[commit-bot: I haz the power, 2016-07-29 18:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:06:09]

Committed patchset #3 (id:2)

[commit-bot: I haz the power, 2016-07-29 21:09:12]

Description was changed from

==========
Add a pre-finalizer to PromiseRejectionEvent

We need to clear ScopedPersistents so that V8 doesn't call phantom callbacks
after Oilpan starts lazy sweeping.

BUG=626893
==========

to

==========
Add a pre-finalizer to PromiseRejectionEvent

We need to clear ScopedPersistents so that V8 doesn't call phantom callbacks
after Oilpan starts lazy sweeping.

BUG=626893

Committed: https://crrev.com/07d2ad752c2749ca67adb8051bf5591f57e06046
Cr-Commit-Position: refs/heads/master@{#408742}
==========

[commit-bot: I haz the power, 2016-07-29 21:09:13]

Patchset 3 (id:??) landed as
https://crrev.com/07d2ad752c2749ca67adb8051bf5591f57e06046
Cr-Commit-Position: refs/heads/master@{#408742}