Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2244343002: Revert of Fix an issue that "save video" context menu appears for MSE video (Closed)

Created:
4 years, 4 months ago by nyquist
Modified:
4 years, 4 months ago
Reviewers:
Yaron, qinmin, DaleCurtis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix an issue that "save video" context menu appears for MSE video (patchset #1 id:1 of https://codereview.chromium.org/2239063004/ ) Reason for revert: Breaks Marshmallow Tablet Tester. See https://crbug.com/637872 for details. Original issue's description: > Fix an issue that "save video" context menu appears for MSE video > > We should use media_flags to determine if a video can be saved. > > BUG=637010 > > Committed: https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e > Cr-Commit-Position: refs/heads/master@{#411807} TBR=yfriedman@chromium.org,dalecurtis@chromium.org,qinmin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=637010, 637872 Committed: https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231 Cr-Commit-Position: refs/heads/master@{#411997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/ui/android/context_menu_helper.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nyquist
Created Revert of Fix an issue that "save video" context menu appears for MSE video
4 years, 4 months ago (2016-08-15 17:45:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244343002/1
4 years, 4 months ago (2016-08-15 17:45:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 18:37:20 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:41:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231
Cr-Commit-Position: refs/heads/master@{#411997}

Powered by Google App Engine
This is Rietveld 408576698