chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 2244343002: Revert of Fix an issue that "save video" context menu appears for MSE video

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2244343002: Revert of Fix an issue that "save video" context menu appears for MSE video (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index 6ea3a7f29204145022347a0d5125906038f77860..09c0ecfb15b703dacf0396d9bd2d1384ec2d6b6c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -247,7 +247,7 @@

if (params.isVideo()) {

menu.findItem(R.id.contextmenu_save_video).setVisible(

- params.canSaveMedia() && UrlUtilities.isDownloadableScheme(params.getSrcUrl()));

+ UrlUtilities.isDownloadableScheme(params.getSrcUrl()));

} else if (params.isImage() && params.imageWasFetchedLoFi()) {

DataReductionProxyUma.dataReductionProxyLoFiUIAction(

DataReductionProxyUma.ACTION_LOAD_IMAGE_CONTEXT_MENU_SHOWN);

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java » ('j') | no next file with comments »