Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2244233007: Revert of [heap] Don't unmap new space pages while sweeping is active (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Don't unmap new space pages while sweeping is active (patchset #4 id:80001 of https://codereview.chromium.org/2250423002/ ) Reason for revert: The barrier in newspace is still needed. Original issue's description: > [heap] Don't unmap new space pages while sweeping is active > > - The barrier for scavenge only checked for whether new space pages were swept. > This is not enough as a concurrent task could still hang right before trying to > lock the page for sweeping. Remove the barrier completely. > - Avoid unmapping of new space pages while sweeping using a delayed list that > gets emptied upon the next call to the unmapper. > > BUG=chromium:628984 > R=hpayer@chromium.org > > Committed: https://crrev.com/982b399423e6bd941cabb2b825031cd8d5eb4980 > Cr-Commit-Position: refs/heads/master@{#38710} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:628984 Committed: https://crrev.com/4a1f2807d6da046367afd243159e40275ad9f8c6 Cr-Commit-Position: refs/heads/master@{#38712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -34 lines) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 3 chunks +1 line, -13 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Lippautz
Created Revert of [heap] Don't unmap new space pages while sweeping is active
4 years, 4 months ago (2016-08-18 11:29:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244233007/1
4 years, 4 months ago (2016-08-18 11:29:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 11:30:01 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 11:30:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a1f2807d6da046367afd243159e40275ad9f8c6
Cr-Commit-Position: refs/heads/master@{#38712}

Powered by Google App Engine
This is Rietveld 408576698