Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: src/heap/spaces.h

Issue 2244233007: Revert of [heap] Don't unmap new space pages while sweeping is active (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index de5ea1b16adc399a977885f4bacffda9c8b22263..ae2f86c32073bd195b377e86e972d997e70767ce 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -1205,12 +1205,7 @@
template <ChunkQueueType type>
void AddMemoryChunkSafe(MemoryChunk* chunk) {
base::LockGuard<base::Mutex> guard(&mutex_);
- if (type != kRegular || allocator_->CanFreeMemoryChunk(chunk)) {
- chunks_[type].push_back(chunk);
- } else {
- DCHECK_EQ(type, kRegular);
- delayed_regular_chunks_.push_back(chunk);
- }
+ chunks_[type].push_back(chunk);
}
template <ChunkQueueType type>
@@ -1222,16 +1217,11 @@
return chunk;
}
- void ReconsiderDelayedChunks();
void PerformFreeMemoryOnQueuedChunks();
base::Mutex mutex_;
MemoryAllocator* allocator_;
std::list<MemoryChunk*> chunks_[kNumberOfChunkQueues];
- // Delayed chunks cannot be processed in the current unmapping cycle because
- // of dependencies such as an active sweeper.
- // See MemoryAllocator::CanFreeMemoryChunk.
- std::list<MemoryChunk*> delayed_regular_chunks_;
base::Semaphore pending_unmapping_tasks_semaphore_;
intptr_t concurrent_unmapping_tasks_active_;
@@ -1269,8 +1259,6 @@
template <MemoryAllocator::FreeMode mode = kFull>
void Free(MemoryChunk* chunk);
-
- bool CanFreeMemoryChunk(MemoryChunk* chunk);
// Returns allocated spaces in bytes.
intptr_t Size() { return size_.Value(); }
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698