[SVGDom] Add <line> support

[SVGDom] Add <line> support

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244223005

Committed: https://skia.googlesource.com/skia/+/d24ee1419f17fe3ac70373ca74136a766522e399

[f(malita), 2016-08-16 22:08:42]

Description was changed from

==========
[SVGDom] Add <line> support

R=robertphillips@google.com,stephana@google.com
==========

to

==========
[SVGDom] Add <line> support

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244223005
==========

[f(malita), 2016-08-16 22:09:36]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 22:09:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 22:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:33:47]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-16 22:47:17]

lgtm

https://codereview.chromium.org/2244223005/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2244223005/diff/1/BUILD.gn#newcode525
BUILD.gn:525: "experimental/svg/model/SkSVGLine.cpp",
Do we not add headers to the .gn files ?

[mtklein, 2016-08-17 00:37:04]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-17 00:37:04]

https://codereview.chromium.org/2244223005/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2244223005/diff/1/BUILD.gn#newcode525
BUILD.gn:525: "experimental/svg/model/SkSVGLine.cpp",
On 2016/08/16 22:47:17, robertphillips wrote:
> Do we not add headers to the .gn files ?

It looks like Chrome does so inconsistently, which I imagine means you can add
them or leave them out completely without consequence, just like good old GYP.

There is another thing called public, meant for headers to be used as the public
interface to a module, here experimental_svg_model.  Steer clear of that.  It's
not clear to me that putting headers in public _does_ anything, beyond perhaps
feeding information into `gn check`.  It doesn't do anything neat like put the
directory containing the headers on the include path... you'd still need that
public_include_dirs bit.

This all looks a little academic as configured right now, as SK_XML is not
defined anywhere in here, s the GN build of DM doesn't build in SVG src support.

[f(malita), 2016-08-17 15:04:15]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:04:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:06:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:06:07]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[f(malita), 2016-08-17 15:08:39]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-17 15:08:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2244223005/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-17 15:08:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:38:17]

Description was changed from

==========
[SVGDom] Add <line> support

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244223005
==========

to

==========
[SVGDom] Add <line> support

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244223005

Committed:
https://skia.googlesource.com/skia/+/d24ee1419f17fe3ac70373ca74136a766522e399
==========

[commit-bot: I haz the power, 2016-08-17 15:38:18]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d24ee1419f17fe3ac70373ca74136a766522e399