[SVGDom] Add <line> support

BUILD.gn

 # Copyright 2016 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 declare_args() {
 }
 
 skia_public_includes = [
   "include/android",
@@ skipping 504 matching lines @@
   ]
 }
 
 test_lib("experimental_svg_model") {
   public_include_dirs = [ "experimental/svg/model" ]
   sources = [
     "experimental/svg/model/SkSVGAttribute.cpp",
     "experimental/svg/model/SkSVGAttributeParser.cpp",
     "experimental/svg/model/SkSVGContainer.cpp",
     "experimental/svg/model/SkSVGDOM.cpp",
+    "experimental/svg/model/SkSVGLine.cpp",

[robertphillips, 2016/08/16 22:47:17]

Do we not add headers to the .gn files ?

[mtklein, 2016/08/17 00:37:04]

It looks like Chrome does so inconsistently, which I imagine means you can add
them or leave them out completely without consequence, just like good old GYP.

There is another thing called public, meant for headers to be used as the public
interface to a module, here experimental_svg_model.  Steer clear of that.  It's
not clear to me that putting headers in public _does_ anything, beyond perhaps
feeding information into `gn check`.  It doesn't do anything neat like put the
directory containing the headers on the include path... you'd still need that
public_include_dirs bit.

This all looks a little academic as configured right now, as SK_XML is not
defined anywhere in here, s the GN build of DM doesn't build in SVG src support.

     "experimental/svg/model/SkSVGNode.cpp",
     "experimental/svg/model/SkSVGPath.cpp",
     "experimental/svg/model/SkSVGPoly.cpp",
     "experimental/svg/model/SkSVGRect.cpp",
     "experimental/svg/model/SkSVGRenderContext.cpp",
     "experimental/svg/model/SkSVGSVG.cpp",
     "experimental/svg/model/SkSVGShape.cpp",
     "experimental/svg/model/SkSVGTransformableNode.cpp",
     "experimental/svg/model/SkSVGValue.cpp",
   ]
@@ skipping 56 matching lines @@
       "tools/SkShaper_harfbuzz.cpp",
       "tools/using_skia_and_harfbuzz.cpp",
     ]
     deps = [
       ":skia",
       "//third_party/harfbuzz",
     ]
     testonly = true
   }
 }