Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: src/gpu/GrReducedClip.h

Issue 2244223004: Make GrReducedClip's gen ID only apply to the element list (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: more improved testing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrClipStackClip.cpp ('k') | src/gpu/GrReducedClip.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrReducedClip.h
diff --git a/src/gpu/GrReducedClip.h b/src/gpu/GrReducedClip.h
index d7b7ea88811c3671389af313b80102142809fff7..a867483de80c66d3259a91ca52b8b82bac06cd63 100644
--- a/src/gpu/GrReducedClip.h
+++ b/src/gpu/GrReducedClip.h
@@ -20,11 +20,6 @@ public:
GrReducedClip(const SkClipStack& stack, const SkRect& queryBounds);
/**
- * Uniquely identifies this reduced clip.
- */
- int32_t genID() const { return fGenID; }
-
- /**
* If hasIBounds() is true, this is the bounding box within which the reduced clip is valid, and
* the caller must not modify any pixels outside this box. Undefined if hasIBounds() is false.
*/
@@ -48,6 +43,12 @@ public:
const ElementList& elements() const { return fElements; }
/**
+ * If elements() are nonempty, uniquely identifies the list of elements within ibounds().
+ * Otherwise undefined.
+ */
+ int32_t elementsGenID() const { SkASSERT(!fElements.isEmpty()); return fElementsGenID; }
+
+ /**
* Indicates whether antialiasing is required to process any of the clip elements.
*/
bool requiresAA() const { return fRequiresAA; }
@@ -60,10 +61,10 @@ public:
InitialState initialState() const { return fInitialState; }
private:
- int32_t fGenID;
SkIRect fIBounds;
bool fHasIBounds;
ElementList fElements;
+ int32_t fElementsGenID;
bool fRequiresAA;
InitialState fInitialState;
};
« no previous file with comments | « src/gpu/GrClipStackClip.cpp ('k') | src/gpu/GrReducedClip.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698