Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2244193002: Revert of Follow-up fix for CL 2130093003 (format -> log_format) (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 4 months ago
Reviewers:
dnj, Dirk Pranke, qyearsley
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Follow-up fix for CL 2130093003 (format -> log_format) (patchset #1 id:1 of https://codereview.chromium.org/2239943004/ ) Reason for revert: https://codereview.chromium.org/2130093003 is causing Linux ASAN bot failure: crbug.com/637664 Original issue's description: > Follow-up fix for CL 2130093003 (format -> log_format) > > BUG=637384 > > Committed: https://crrev.com/faa9fe2108f48a8a31a44a5e4d75c632971b03ff > Cr-Commit-Position: refs/heads/master@{#411795} TBR=dnj@chromium.org,dpranke@chromium.org,qyearsley@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=637384 Committed: https://crrev.com/54f8ab219ad04c900c20a8b62295c3a0aef0c979 Cr-Commit-Position: refs/heads/master@{#411948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
hiroshige
Created Revert of Follow-up fix for CL 2130093003 (format -> log_format)
4 years, 4 months ago (2016-08-15 07:50:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244193002/1
4 years, 4 months ago (2016-08-15 07:50:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 08:53:43 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 08:55:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54f8ab219ad04c900c20a8b62295c3a0aef0c979
Cr-Commit-Position: refs/heads/master@{#411948}

Powered by Google App Engine
This is Rietveld 408576698