Fix pylint warnings in webkitpy/common/.

Fix pylint warnings in webkitpy/common/.

Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
Cr-Commit-Position: refs/heads/master@{#411710}

[qyearsley, 2016-07-07 23:26:51]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-07-11 16:40:09]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 16:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 17:51:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 17:51:30]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-07-20 23:24:35]

qyearsley@chromium.org changed reviewers:
+ tansell@chromium.org

[qyearsley, 2016-07-21 17:51:30]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:03:46]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-08-09 03:44:12]

lgtm (very belatedly).

[qyearsley, 2016-08-09 04:31:51]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 04:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 06:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 06:05:58]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-08-11 22:32:41]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 22:33:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:42:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:42:15]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-08-12 16:29:49]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-08-12 16:29:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2130093003/#ps40001
(title: "Rebase and fix most newly-enabled pylint warnings.")

[commit-bot: I haz the power, 2016-08-12 16:30:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 16:36:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 16:36:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qyearsley, 2016-08-12 16:54:57]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-08-12 16:54:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2130093003/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-08-12 16:55:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:30:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-12 18:33:18]

Description was changed from

==========
Fix pylint warnings in webkitpy/common/.
==========

to

==========
Fix pylint warnings in webkitpy/common/.

Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
Cr-Commit-Position: refs/heads/master@{#411710}
==========

[commit-bot: I haz the power, 2016-08-12 18:33:19]

Patchset 4 (id:??) landed as
https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
Cr-Commit-Position: refs/heads/master@{#411710}

[hiroshige, 2016-08-15 08:55:33]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2248653002/ by hiroshige@chromium.org.

The reason for reverting is: Causing Linux ASAN bot failure:
crbug.com/637664

BUG=637664
.

[qyearsley, 2016-08-15 15:51:03]

On 2016/08/15 at 08:55:33, hiroshige wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2248653002/ by hiroshige@chromium.org.
> 
> The reason for reverting is: Causing Linux ASAN bot failure:
> crbug.com/637664
> 
> BUG=637664
> .

Looks like with this CL I was trying to do too many unrelated things in one CL,
and changed names of arguments in a couple places but not others.

This, in addition to the fact that test coverage in webkitpy is not complete has
meant that this change caused two failures on the bots that I didn't discover
before committing. I think that in general for changes like this, it's better to
make more specific CLs (fix instances of warning X, or rename argument Y) rather
than general ones (fix all warnings in a large directory).