Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2243843002: [ARM64] Optimize load followed by shift. (Closed)

Created:
4 years, 4 months ago by georgia.kouveli
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM64] Optimize load followed by shift. Instead of loading 64 bits and shifting: ldr x0, [x1, #offset] asr x0, x0, #32 directly load the interesting 32 bits and sign-extend: ldrsw x0, [x1, #offset+4] BUG= Committed: https://crrev.com/dc6b5109d7ee98965812c5a30bac413e3c29acfa Cr-Commit-Position: refs/heads/master@{#38622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 3 chunks +76 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
georgia.kouveli
Resurrecting patch set 1 of https://codereview.chromium.org/2183923003. I've removed the second pattern from the old patchset ...
4 years, 4 months ago (2016-08-12 12:41:20 UTC) #2
epertoso
lgtm Thanks!
4 years, 4 months ago (2016-08-12 13:32:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243843002/1
4 years, 4 months ago (2016-08-12 13:33:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 13:55:36 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 13:55:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc6b5109d7ee98965812c5a30bac413e3c29acfa
Cr-Commit-Position: refs/heads/master@{#38622}

Powered by Google App Engine
This is Rietveld 408576698