Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Issue 2242633002: Android: Force draw for pending readbacks during Display teardown (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 4 months ago
Reviewers:
jbauman
CC:
chromium-reviews, jam, cc-bugs_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tn1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Force draw for pending readbacks during Display teardown The Surface goes away when the activity is stopped. Since this is an interesting point in time to grab a placeholder for the web contents, try to complete pending readbacks that might have just been issues before tearing down the Display. BUG=636630, 637035 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/962aa721a0de39986c7c393e154f773f7b74bdf4 Cr-Commit-Position: refs/heads/master@{#411706}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M cc/surfaces/display.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/surfaces/display.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 4 chunks +15 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (22 generated)
no sievers
ptal
4 years, 4 months ago (2016-08-11 22:24:40 UTC) #6
jbauman
lgtm
4 years, 4 months ago (2016-08-11 22:51:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242633002/40001
4 years, 4 months ago (2016-08-12 17:52:22 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 18:26:33 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 18:28:42 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/962aa721a0de39986c7c393e154f773f7b74bdf4
Cr-Commit-Position: refs/heads/master@{#411706}

Powered by Google App Engine
This is Rietveld 408576698