Issue 224363003: Re-land "cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224363003: Re-land "cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture" (Closed)

Created:
6 years, 8 months ago by ncarter (slow)

Modified:
6 years, 8 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Re-land "cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture" Reason for re-land: Change was found not guilty; charges were dropped. > Revert 261380 "cc: Remove TextureLayer::SetTextureId and Texture..." > > [Reason for revert: failure in WindowUtilTest.RecreateLayers > in test suite wm_core_unittests > on bot Linux ChromiumOS Tests (dbg)(1) Build] > > > cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture > > > > These are not used anymore except for clearing the client-provided texture, so > > this removes 1 of 4 TextureLayer paths, and simplifies externally-exposed state. > > > > BUG=337922 > > > > Review URL: https://codereview.chromium.org/213743005 > > TBR=piman@chromium.org > > Review URL: https://codereview.chromium.org/224153003 TBR=nick@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261490

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+238 lines, -164 lines)			Patch
M	trunk/src/cc/layers/texture_layer.h	View	4 chunks	+13 lines, -7 lines	0 comments	Download
M	trunk/src/cc/layers/texture_layer.cc	View	6 chunks	+21 lines, -27 lines	0 comments	Download
M	trunk/src/cc/layers/texture_layer_unittest.cc	View	8 chunks	+200 lines, -121 lines	0 comments	Download
M	trunk/src/content/shell/renderer/test_runner/TestPlugin.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	trunk/src/ui/compositor/layer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/webkit/renderer/compositor_bindings/web_external_texture_layer_impl.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r261490.

Expand Messages | Collapse Messages