Issue 224153003: Revert 261380 "cc: Remove TextureLayer::SetTextureId and Texture..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224153003: Revert 261380 "cc: Remove TextureLayer::SetTextureId and Texture..." (Closed)

Created:
6 years, 8 months ago by ncarter (slow)

Modified:
6 years, 8 months ago

Reviewers:
piman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 261380 "cc: Remove TextureLayer::SetTextureId and Texture..." [Reason for revert: failure in WindowUtilTest.RecreateLayers in test suite wm_core_unittests on bot Linux ChromiumOS Tests (dbg)(1) Build] > cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture > > These are not used anymore except for clearing the client-provided texture, so > this removes 1 of 4 TextureLayer paths, and simplifies externally-exposed state. > > BUG=337922 > > Review URL: https://codereview.chromium.org/213743005 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261460

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+164 lines, -238 lines)			Patch
M	trunk/src/cc/layers/texture_layer.h	View	4 chunks	+7 lines, -13 lines	0 comments	Download
M	trunk/src/cc/layers/texture_layer.cc	View	6 chunks	+27 lines, -21 lines	0 comments	Download
M	trunk/src/cc/layers/texture_layer_unittest.cc	View	8 chunks	+121 lines, -200 lines	0 comments	Download
M	trunk/src/content/shell/renderer/test_runner/TestPlugin.cpp	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	trunk/src/ui/compositor/layer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/webkit/renderer/compositor_bindings/web_external_texture_layer_impl.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

6 years, 8 months ago (2014-04-03 17:19:02 UTC) #3

Link to specific failure:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

On Thu, Apr 3, 2014 at 10:16 AM, <nick@chromium.org> wrote:

> Committed patchset #1 manually as r261460.
>
> https://codereview.chromium.org/224153003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages