ARC: Show window title in launcher menu instead of app title

chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
 #include "chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_v2app.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 #include "chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h"
+#include "ui/aura/window.h"
+#include "ui/base/base_window.h"
 
 ArcAppWindowLauncherItemController::ArcAppWindowLauncherItemController(
     const std::string& arc_app_id,
     ChromeLauncherController* controller)
     : AppWindowLauncherItemController(TYPE_APP,
                                       arc_app_id,
                                       arc_app_id,
                                       controller) {}
 
 ArcAppWindowLauncherItemController::~ArcAppWindowLauncherItemController() {}
@@ skipping 14 matching lines @@
 
 ash::ShelfMenuModel* ArcAppWindowLauncherItemController::CreateApplicationMenu(
     int event_flags) {
   return new LauncherApplicationMenuItemModel(GetApplicationList(event_flags));
 }
 
 ChromeLauncherAppMenuItems
 ArcAppWindowLauncherItemController::GetApplicationList(int event_flags) {
   ChromeLauncherAppMenuItems items =
       AppWindowLauncherItemController::GetApplicationList(event_flags);
-  for (size_t i = 0; i < windows().size(); ++i) {
+  size_t i = 0;
+  for (auto it = windows().begin(); it != windows().end(); ++it, ++i) {

[James Cook, 2016/08/17 21:41:33]

Dumb question: windows() always has an even number of items? So it is safe to do
++it, ++it without testing against end()?

[yoshiki, 2016/08/23 08:23:56]

The second incremented variable is not "it" but "i".

[oshima, 2016/08/23 19:03:08]

FYI: you can get the index by "itr - windows().begin()". 

     // TODO(khmel): resolve correct icon here.
     gfx::Image image;
+    aura::Window* window = (*it)->GetNativeWindow();
     items.push_back(new ChromeLauncherAppMenuItemV2App(
-        GetTitle(), &image, app_id(), launcher_controller(), i,
-        i == 0 /* has_leading_separator */));
+        (window ? window->title() : GetTitle()), &image, app_id(),

[Mr4D (OOO till 08-26), 2016/08/11 18:46:57]

Would it make sense to use GetTitle() if the window title is empty?

[yoshiki, 2016/08/11 19:41:57]

Yes. I think showing empty title is weird and should be fallen back to the app
title.

[oshima, 2016/08/16 17:57:18]

Did you implement this?

+        launcher_controller(), i, i == 0 /* has_leading_separator */));
   }
   return items;
 }