third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html - Issue 2243473002: Adding overflow menu to media player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/media/media-controls-play-button-visible.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

diff --git a/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html b/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

index abf9bfb530735d2394d9285f7f44e3b4afafa683..f46b8f29740ed9398d3ffdf6077e71f20a68bbfd 100644

--- a/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

+++ b/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

@@ -1,18 +1,29 @@

<!DOCTYPE html>

-<title>Tests that the fullscreen button control is visible last.</title>

+<title>Tests that the fullscreen button control is the antepenultimate media controls button visible.</title>

+<script src="overflow-menu.js"></script>

async_test(function(t) {

var video = document.querySelector("video");

video.src = findMediaFile("video", "content/test");

- video.setAttribute("width", "70");

+ // Since this is a video, we'll have three elements visible when the width

+ // is 120. These three should be: play, fullscreen, overflow.

+ video.setAttribute("width", "120");

video.addTextTrack("captions");

video.onloadeddata = t.step_func_done(function() {

+ // Play button should be visible

+ var playButton = mediaControlsButton(video, "play-button");

+ assert_not_equals(getComputedStyle(playButton).display, "none");

+ // Full screen button should be visible

assert_true(hasFullscreenButton(video));

+ // Overflow menu button should be visible

+ var overflowMenuButton = getOverflowMenuButton(video);

+ assert_not_equals(getComputedStyle(overflowMenuButton).display, "none");

+ // Closed captions shouldn't

assert_false(isClosedCaptionsButtonVisible(video));

});