third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html - Issue 2243473002: Adding overflow menu to media player

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/media/media-controls-play-button-visible.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Tests that the fullscreen button control is visible last.</title>	2 <title>Tests that the fullscreen button control is the antepenultimate media con trols button visible.</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script src="media-controls.js"></script>	6 <script src="media-controls.js"></script>

	7 <script src="overflow-menu.js"></script>

7 <video controls></video>	8 <video controls></video>

8 <script>	9 <script>

9 async_test(function(t) {	10 async_test(function(t) {

10 var video = document.querySelector("video");	11 var video = document.querySelector("video");

11 video.src = findMediaFile("video", "content/test");	12 video.src = findMediaFile("video", "content/test");

12 video.setAttribute("width", "70");	13 // Since this is a video, we'll have three elements visible when the width

	14 // is 120. These three should be: play, fullscreen, overflow.

	15 video.setAttribute("width", "120");

13 video.addTextTrack("captions");	16 video.addTextTrack("captions");

14 video.onloadeddata = t.step_func_done(function() {	17 video.onloadeddata = t.step_func_done(function() {

	18 // Play button should be visible

	19 var playButton = mediaControlsButton(video, "play-button");

	20 assert_not_equals(getComputedStyle(playButton).display, "none");

	21 // Full screen button should be visible

15 assert_true(hasFullscreenButton(video));	22 assert_true(hasFullscreenButton(video));

	23 // Overflow menu button should be visible

	24 var overflowMenuButton = getOverflowMenuButton(video);

	25 assert_not_equals(getComputedStyle(overflowMenuButton).display, "none");

	26 // Closed captions shouldn't

16 assert_false(isClosedCaptionsButtonVisible(video));	27 assert_false(isClosedCaptionsButtonVisible(video));

17 });	28 });

18 });	29 });

19 </script>	30 </script>

OLD	NEW