Adding overflow menu to media player

third_party/WebKit/Source/core/html/shadow/MediaControls.h

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
index 8b5892229a9919dc173917c16384231f1a0d6e78..65677e7e73ae99497747b538c272ec575b799541 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
@@ -86,6 +86,14 @@ public:
     // Notify us that the media element's network state has changed.
     void networkStateChanged();
 
+    void toggleOverflowMenu();
+
+    bool overflowMenuVisible();
+
+    // Returns a list of all possible controls that can appear in an overflow
+    // menu.
+    std::vector<MediaControlInputElement*> getOverflowMenuButtons();

[liberato (no reviews please), 2016/08/24 16:44:22]

perhaps pass by ref to prevent a copy.  const ref would be okay in this case, i
think.

or, alternatively, since this is only used by the the overflow list element when
setting the overflow controls, just pass a const ref as an argument.  it's
already doing that for the list of controls that didn't fit; might as well just
send both lists.

[kdsilva, 2016/08/26 18:11:03]

Acknowledged.

+
     DECLARE_VIRTUAL_TRACE();
 
 private:
@@ -127,6 +135,8 @@ private:
     void defaultEventHandler(Event*) override;
     bool containsRelatedTarget(Event*);
 
+    std::vector<MediaControlInputElement*> controlsListOverflow;
+
     Member<HTMLMediaElement> m_mediaElement;
 
     // Media control elements.
@@ -143,6 +153,13 @@ private:
     Member<MediaControlVolumeSliderElement> m_volumeSlider;
     Member<MediaControlToggleClosedCaptionsButtonElement> m_toggleClosedCaptionsButton;
     Member<MediaControlTextTrackListElement> m_textTrackList;
+    Member<MediaControlOverflowMenu> m_overflowMenu;
+    Member<MediaControlOverflowMenuListElement> m_overflowList;
+    Member<MediaControlMuteButtonElement> m_muteOverflowButton;
+    Member<MediaControlCastButtonElement> m_castOverflowButton;
+    Member<MediaControlToggleClosedCaptionsButtonElement> m_closedCaptionsOverflowButton;
+    Member<MediaControlFullscreenButtonElement> m_fullscreenOverflowButton;
+
     Member<MediaControlCastButtonElement> m_castButton;
     Member<MediaControlFullscreenButtonElement> m_fullScreenButton;