Adding overflow menu to media player

third_party/WebKit/Source/core/html/shadow/MediaControls.h

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 68 matching lines @@
     // Returns the layout object for the part of the controls that should be
     // used for overlap checking during text track layout. May be null.
     LayoutObject* layoutObjectForTextTrackLayout();
 
     // Notify us that our controls enclosure has changed width.
     void notifyPanelWidthChanged(const LayoutUnit& newWidth);
 
     // Notify us that the media element's network state has changed.
     void networkStateChanged();
 
+    void toggleOverflowMenu();
+
+    bool overflowMenuVisible();
+
+    // Returns a list of all possible controls that can appear in an overflow
+    // menu.
+    std::vector<MediaControlInputElement*> getOverflowMenuButtons();

[liberato (no reviews please), 2016/08/24 16:44:22]

perhaps pass by ref to prevent a copy.  const ref would be okay in this case, i
think.

or, alternatively, since this is only used by the the overflow list element when
setting the overflow controls, just pass a const ref as an argument.  it's
already doing that for the list of controls that didn't fit; might as well just
send both lists.

[kdsilva, 2016/08/26 18:11:03]

Acknowledged.

+
     DECLARE_VIRTUAL_TRACE();
 
 private:
     void invalidate(Element*);
 
     class BatchedControlUpdate;
 
     explicit MediaControls(HTMLMediaElement&);
 
     void initializeControls();
@@ skipping 21 matching lines @@
     // Hide elements that don't fit, and show those things that we want which
     // do fit.  This requires that m_panelWidth is current.
     void computeWhichControlsFit();
 
     // Node
     bool isMediaControls() const override { return true; }
     bool willRespondToMouseMoveEvents() override { return true; }
     void defaultEventHandler(Event*) override;
     bool containsRelatedTarget(Event*);
 
+    std::vector<MediaControlInputElement*> controlsListOverflow;
+
     Member<HTMLMediaElement> m_mediaElement;
 
     // Media control elements.
     Member<MediaControlOverlayEnclosureElement> m_overlayEnclosure;
     Member<MediaControlOverlayPlayButtonElement> m_overlayPlayButton;
     Member<MediaControlCastButtonElement> m_overlayCastButton;
     Member<MediaControlPanelEnclosureElement> m_enclosure;
     Member<MediaControlPanelElement> m_panel;
     Member<MediaControlPlayButtonElement> m_playButton;
     Member<MediaControlTimelineElement> m_timeline;
     Member<MediaControlCurrentTimeDisplayElement> m_currentTimeDisplay;
     Member<MediaControlTimeRemainingDisplayElement> m_durationDisplay;
     Member<MediaControlMuteButtonElement> m_muteButton;
     Member<MediaControlVolumeSliderElement> m_volumeSlider;
     Member<MediaControlToggleClosedCaptionsButtonElement> m_toggleClosedCaptionsButton;
     Member<MediaControlTextTrackListElement> m_textTrackList;
+    Member<MediaControlOverflowMenu> m_overflowMenu;
+    Member<MediaControlOverflowMenuListElement> m_overflowList;
+    Member<MediaControlMuteButtonElement> m_muteOverflowButton;
+    Member<MediaControlCastButtonElement> m_castOverflowButton;
+    Member<MediaControlToggleClosedCaptionsButtonElement> m_closedCaptionsOverflowButton;
+    Member<MediaControlFullscreenButtonElement> m_fullscreenOverflowButton;
+
     Member<MediaControlCastButtonElement> m_castButton;
     Member<MediaControlFullscreenButtonElement> m_fullScreenButton;
 
     Timer<MediaControls> m_hideMediaControlsTimer;
     unsigned m_hideTimerBehaviorFlags;
     bool m_isMouseOverControls : 1;
     bool m_isPausedForScrubbing : 1;
 
     Timer<MediaControls> m_panelWidthChangedTimer;
     int m_panelWidth;
 
     bool m_allowHiddenVolumeControls : 1;
 };
 
 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());
 
 } // namespace blink
 
 #endif