Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2243353002: (Reland) Update all Robolectric tests to Robolectric 3.0 (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
CC:
asanka, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dominickn+watch_chromium.org, feature-media-reviews_chromium.org, jam, jbudorick+watch_chromium.org, media-router+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Update all Robolectric tests to Robolectric 3.0 BUG=522043 Committed: https://crrev.com/cf5bc93dae70d15f712f45daf2fb2d696d8241ad Cr-Commit-Position: refs/heads/master@{#412564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -575 lines) Patch
M base/BUILD.gn View 2 chunks +1 line, -15 lines 0 comments Download
M base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java View 3 chunks +5 lines, -3 lines 0 comments Download
M base/android/junit/src/org/chromium/base/PromiseTest.java View 11 chunks +13 lines, -13 lines 0 comments Download
D base/test/android/junit/src/org/chromium/base/test/shadows/ShadowMultiDex.java View 1 chunk +0 lines, -21 lines 0 comments Download
M base/test/android/junit/src/org/chromium/base/test/util/DisableIfTest.java View 12 chunks +29 lines, -35 lines 0 comments Download
M base/test/android/junit/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheckTest.java View 5 chunks +10 lines, -10 lines 0 comments Download
M build/android/pylib/junit/test_runner.py View 1 chunk +6 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntryTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencerTest.java View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/gcore/GoogleApiClientHelperTest.java View 16 chunks +42 lines, -50 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 11 chunks +28 lines, -26 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterRouteTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterSinkObservationTest.java View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterTestBase.java View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallbackTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/TestUtils.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java View 9 chunks +27 lines, -15 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java View 3 chunks +16 lines, -12 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ClientIdTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java View 2 chunks +1 line, -1 line 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTestRunner.java View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowGcmNetworkManager.java View 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java View 11 chunks +19 lines, -18 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java View 26 chunks +103 lines, -89 lines 0 comments Download
M chrome/android/webapk/libs/client/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java View 5 chunks +11 lines, -8 lines 0 comments Download
M chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java View 9 chunks +11 lines, -10 lines 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java View 5 chunks +6 lines, -6 lines 0 comments Download
M components/invalidation/impl/android/junit/src/org/chromium/components/invalidation/PendingInvalidationTest.java View 1 chunk +6 lines, -4 lines 0 comments Download
M components/policy/android/junit/src/org/chromium/policy/AbstractAppRestrictionsProviderTest.java View 7 chunks +13 lines, -11 lines 0 comments Download
M components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/WebRestrictionsClientTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/WebRestrictionsContentProviderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java View 14 chunks +14 lines, -13 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java View 3 chunks +3 lines, -0 lines 0 comments Download
M net/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java View 4 chunks +5 lines, -4 lines 0 comments Download
M testing/android/junit/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/BackgroundShadowAsyncTask.java View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java View 1 chunk +17 lines, -23 lines 0 comments Download
D testing/android/junit/java/src/org/chromium/testing/local/RobolectricClasspathDependencyResolver.java View 1 chunk +0 lines, -72 lines 0 comments Download
M third_party/robolectric/BUILD.gn View 3 chunks +4 lines, -20 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/junit/src/org/chromium/ui/picker/DateDialogNormalizerTest.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
mikecase (-- gone --)
Had to revert CL because in between me doing a CQ-dry-run and committing the CL, ...
4 years, 4 months ago (2016-08-15 18:05:52 UTC) #2
jbudorick
On 2016/08/15 18:05:52, mikecase wrote: > Had to revert CL because in between me doing ...
4 years, 4 months ago (2016-08-15 18:10:10 UTC) #3
Lei Zhang
rs lgtm
4 years, 4 months ago (2016-08-15 18:33:21 UTC) #4
Cait (Slow)
rs lgtm for components/
4 years, 4 months ago (2016-08-15 18:47:59 UTC) #5
Ted C
On 2016/08/15 18:47:59, Cait (slow) wrote: > rs lgtm for components/ rs lgtm
4 years, 4 months ago (2016-08-15 20:38:13 UTC) #6
cbentzel
On 2016/08/15 20:38:13, Ted C wrote: > On 2016/08/15 18:47:59, Cait (slow) wrote: > > ...
4 years, 4 months ago (2016-08-15 22:10:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243353002/1
4 years, 4 months ago (2016-08-17 16:01:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 16:53:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 16:55:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf5bc93dae70d15f712f45daf2fb2d696d8241ad
Cr-Commit-Position: refs/heads/master@{#412564}

Powered by Google App Engine
This is Rietveld 408576698