Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2239003002: Revert of [Android] Update all Robolectric tests to Robolectric 3.0 (Closed)

Created:
4 years, 4 months ago by mikecase (-- gone --)
Modified:
4 years, 4 months ago
CC:
cbentzel+watch_chromium.org, Changwan Ryu, chromium-reviews, darin-cc_chromium.org, dgn, dominickn+watch_chromium.org, feature-media-reviews_chromium.org, jam, jbudorick+watch_chromium.org, media-router+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Update all Robolectric tests to Robolectric 3.0 (patchset #14 id:260001 of https://codereview.chromium.org/2195143002/ ) Reason for revert: Compile errors here... https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/71108/steps/compile/logs/stdio Original issue's description: > Update all Robolectric tests to Robolectric 3.0 > > BUG=522043 > > Committed: https://crrev.com/de621335b3d5b104587934b51cf83eb17911b14a > Cr-Commit-Position: refs/heads/master@{#411362} TBR=aberent@chromium.org,caitkp@chromium.org,jbudorick@chromium.org,nyquist@chromium.org,cbentzel@chromium.org,tedchoc@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522043 Committed: https://crrev.com/aab3f54067c45400063f8d088274edf5aa9add6f Cr-Commit-Position: refs/heads/master@{#411367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+626 lines, -553 lines) Patch
M base/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
M base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java View 3 chunks +3 lines, -5 lines 0 comments Download
A base/test/android/junit/src/org/chromium/base/test/shadows/ShadowMultiDex.java View 1 chunk +21 lines, -0 lines 0 comments Download
M base/test/android/junit/src/org/chromium/base/test/util/DisableIfTest.java View 12 chunks +35 lines, -29 lines 0 comments Download
M base/test/android/junit/src/org/chromium/base/test/util/MinAndroidSdkLevelSkipCheckTest.java View 5 chunks +10 lines, -10 lines 0 comments Download
M build/android/pylib/junit/test_runner.py View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencerTest.java View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/gcore/GoogleApiClientHelperTest.java View 16 chunks +54 lines, -46 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 11 chunks +53 lines, -55 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterRouteTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterSinkObservationTest.java View 3 chunks +6 lines, -12 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterTestBase.java View 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/DiscoveryCallbackTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/TestUtils.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java View 9 chunks +15 lines, -27 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java View 3 chunks +12 lines, -16 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ClientIdTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java View 2 chunks +1 line, -1 line 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTestRunner.java View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowGcmNetworkManager.java View 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java View 11 chunks +19 lines, -20 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java View 26 chunks +120 lines, -134 lines 0 comments Download
M chrome/android/webapk/libs/client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java View 5 chunks +8 lines, -11 lines 0 comments Download
M chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java View 9 chunks +10 lines, -11 lines 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java View 5 chunks +6 lines, -6 lines 0 comments Download
M components/invalidation/impl/android/junit/src/org/chromium/components/invalidation/PendingInvalidationTest.java View 1 chunk +4 lines, -6 lines 0 comments Download
M components/policy/android/junit/src/org/chromium/policy/AbstractAppRestrictionsProviderTest.java View 7 chunks +11 lines, -13 lines 0 comments Download
M components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/WebRestrictionsClientTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/WebRestrictionsContentProviderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java View 14 chunks +13 lines, -14 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java View 3 chunks +0 lines, -3 lines 0 comments Download
M net/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java View 4 chunks +4 lines, -5 lines 0 comments Download
M testing/android/junit/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/BackgroundShadowAsyncTask.java View 2 chunks +3 lines, -3 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java View 1 chunk +23 lines, -17 lines 0 comments Download
A testing/android/junit/java/src/org/chromium/testing/local/RobolectricClasspathDependencyResolver.java View 1 chunk +72 lines, -0 lines 0 comments Download
M third_party/robolectric/BUILD.gn View 3 chunks +20 lines, -4 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/junit/src/org/chromium/ui/picker/DateDialogNormalizerTest.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mikecase (-- gone --)
Created Revert of [Android] Update all Robolectric tests to Robolectric 3.0
4 years, 4 months ago (2016-08-11 17:21:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239003002/1
4 years, 4 months ago (2016-08-11 17:21:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 17:23:54 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 17:26:36 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aab3f54067c45400063f8d088274edf5aa9add6f
Cr-Commit-Position: refs/heads/master@{#411367}

Powered by Google App Engine
This is Rietveld 408576698