Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2243343002: [Android] Stop using --flakiness-dashboard-server for gtests. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Stop using --flakiness-dashboard-server for gtests. It's being replaced by recipe-side calls to api.test_results.upload. BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/cb3be09237faaf011f12e22b53910f98146733dc

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 2 chunks +1 line, -4 lines 2 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest_asan_android.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__trial__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Android__Nexus4_.json View 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___K_Nexus5_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus5_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus6_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus7_2_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus9_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
4 years, 4 months ago (2016-08-15 17:49:54 UTC) #2
ghost stip (do not use)
lgtm w/ check https://codereview.chromium.org/2243343002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (left): https://codereview.chromium.org/2243343002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#oldcode1078 scripts/slave/recipe_modules/chromium_android/api.py:1078: gtest_filter=None, tool=None, flakiness_dashboard=None, can you make ...
4 years, 4 months ago (2016-08-15 18:25:17 UTC) #3
jbudorick
https://codereview.chromium.org/2243343002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (left): https://codereview.chromium.org/2243343002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#oldcode1078 scripts/slave/recipe_modules/chromium_android/api.py:1078: gtest_filter=None, tool=None, flakiness_dashboard=None, On 2016/08/15 18:25:17, stip wrote: > ...
4 years, 4 months ago (2016-08-15 18:27:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243343002/1
4 years, 4 months ago (2016-08-15 18:28:06 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:31:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/cb3be09237faaf011f12...

Powered by Google App Engine
This is Rietveld 408576698