Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2066)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2243343002: [Android] Stop using --flakiness-dashboard-server for gtests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/steps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index d6a873adba29115ba3fd11c1360575c9d817e930..c5aaf39e75a1cffe99a208887aaf3c6d1c26b949 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -1075,7 +1075,7 @@ class AndroidApi(recipe_api.RecipeApi):
'-w', self.m.path['slave_build']] + args, **kwargs)
def run_test_suite(self, suite, verbose=True, isolate_file_path=None,
- gtest_filter=None, tool=None, flakiness_dashboard=None,
ghost stip (do not use) 2016/08/15 18:25:17 can you make sure this doesn't break internally
jbudorick 2016/08/15 18:27:44 Already did.
+ gtest_filter=None, tool=None,
name=None, json_results_file=None, shard_timeout=None,
args=None, **kwargs):
args = args or []
@@ -1090,9 +1090,6 @@ class AndroidApi(recipe_api.RecipeApi):
args.append('--gtest_filter=%s' % gtest_filter)
if tool:
args.append('--tool=%s' % tool)
- if flakiness_dashboard:
- args.append('--flakiness-dashboard-server=%s' %
- flakiness_dashboard)
if json_results_file:
args.extend(['--json-results-file', json_results_file])
# TODO(agrieve): Remove once no more tests pass shard_timeout (contained in
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/steps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698